nixos/usbmuxd: Fix incorrect pkg for udevadm#268813
Closed
amarshall wants to merge 1 commit intoNixOS:masterfrom
Closed
nixos/usbmuxd: Fix incorrect pkg for udevadm#268813amarshall wants to merge 1 commit intoNixOS:masterfrom
amarshall wants to merge 1 commit intoNixOS:masterfrom
Conversation
4a91337 to
a0c903c
Compare
12 tasks
amarshall
commented
Nov 20, 2023
| # Trigger the udev rule manually. This doesn't require replugging the | ||
| # device when first enabling the option to get it to work | ||
| ExecStartPre = "${pkgs.udev}/bin/udevadm trigger -s usb -a idVendor=${apple}"; | ||
| ExecStartPre = "${pkgs.systemdMinimal}/bin/udevadm trigger -s usb -a idVendor=${apple}"; |
Member
Author
There was a problem hiding this comment.
Or maybe just systemd? Not sure which would be preferred in this context.
camillemndn
approved these changes
Nov 23, 2023
Member
Author
|
Fixed in #268718 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Believe this was broken by 856d007. Not sure if this change is correct or if
udevshould be changed tosystemdMinimalmore broadly.Description of changes
Things done
Tested my own system that was failing to start usbmuxd, with this patch succeeds.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)