Skip to content

skarnet.org November 2023 release (2)#268744

Merged
5 commits merged intoNixOS:masterfrom
alyssais:skarnet-2023-11.2
Nov 30, 2023
Merged

skarnet.org November 2023 release (2)#268744
5 commits merged intoNixOS:masterfrom
alyssais:skarnet-2023-11.2

Conversation

@alyssais
Copy link
Copy Markdown
Member

@alyssais alyssais commented Nov 20, 2023

Description of changes

http://skarnet.org/lists/skaware/1908.html

I'm inclined to consider the s6-networking changes non-breaking for release purposes, since it sounds like the circumstances in which they are breaking are very minor.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Nov 20, 2023
@alyssais
Copy link
Copy Markdown
Member Author

alyssais commented Nov 20, 2023

Updated for http://skarnet.org/lists/skaware/1910.html.

ghost
ghost approved these changes Nov 30, 2023
View reviewed changes
Copy link
Copy Markdown

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the title of the commit "s6: 2.12.0.0 -> 2.12.0.1" to "s6: 2.12.0.0 -> 2.12.0.2"?

s6 2.12.0.1 had a nasty bug, so we don't want to scare anybody.

Built on:

  • x86_64-linux
  • aarch64-linux
  • powerpc64le-linux
  • mips64el-linux

@alyssais
Copy link
Copy Markdown
Member Author

alyssais commented Nov 30, 2023

Good catch; will do.

@ghost ghost mentioned this pull request Nov 30, 2023
Closed
@ghost ghost merged commit 8d0f0ca into NixOS:master Nov 30, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 30, 2023

Successfully created backport PR for release-23.11:

@github-actions github-actions bot mentioned this pull request Nov 30, 2023
Merged
1 task
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alyssais