changelog-d: init / justStaticExecutables#268487
Merged
roberth merged 7 commits intoNixOS:haskell-updatesfrom Nov 19, 2023
Merged
changelog-d: init / justStaticExecutables#268487roberth merged 7 commits intoNixOS:haskell-updatesfrom
justStaticExecutables#268487roberth merged 7 commits intoNixOS:haskell-updatesfrom
Conversation
Move the overrides to top-level (pkgs/by-name).
I couldn't get the separate bin output to work.
79f1fa7 to
eb8dafd
Compare
infinisil
approved these changes
Nov 19, 2023
Member
infinisil
left a comment
There was a problem hiding this comment.
Technically this is a minor breaking change, since e.g. haskellPackages.changelog-d.tests doesn't exist anymore. Same for updateScript and the -git- version suffix.
This is fairly internal however, so I guess it might be fine.
Otherwise this looks good!
Member
Author
|
Yeah, you'd have to use this git-only project as a library to find these changes. Basically you'd be asking for it. |
Contributor
|
Successfully created backport PR for |
1 task
Contributor
|
Git push to origin failed for release-23.05 with exitcode 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
changelog-dhad an unnecessarily large runtime closure.Description of changes
justStaticExecutableschangelog-da top level packageThe combined PR diff doesn't understand the file move, so it's easier to review individual commits.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)