Merged
Conversation
hping tries to run a compiled binary to detect endianness, and also runs the end-product of the build process with `-v` for some reason after the build completes. This commit addresses both of these behaviors. Tested on: - [x] mips64el-linux-gnu (cross from x86_64-linux) - [x] aarch64-linux-gnu (cross from x86_64-linux)
bjornfor
approved these changes
Nov 13, 2023
Contributor
|
Tested building, that all works fine now vs it not working before. |
Mindavi
approved these changes
Dec 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
hping tries to run a compiled binary to detect endianness, and also
runs the end-product of the build process with
-vfor some reasonafter the build completes.
This commit addresses both of these behaviors.
Tested on:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)