Skip to content

python311Packages.zope-dottedname: 5.0 -> 6.0; rename from zope_dottedname#266889

Merged
fabaff merged 3 commits intoNixOS:masterfrom
natsukium:zope-dottedname
Nov 12, 2023
Merged

python311Packages.zope-dottedname: 5.0 -> 6.0; rename from zope_dottedname#266889
fabaff merged 3 commits intoNixOS:masterfrom
natsukium:zope-dottedname

Conversation

@natsukium
Copy link
Copy Markdown
Member

@natsukium natsukium commented Nov 11, 2023

Description of changes

Changelog: https://github.com/zopefoundation/zope.dottedname/blob/6.0/CHANGES.rst

part of #245383

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 11, 2023
@natsukium natsukium mentioned this pull request Nov 11, 2023
Closed
@natsukium
Copy link
Copy Markdown
Member Author

natsukium commented Nov 11, 2023

Result of nixpkgs-review pr 266889 at ecd0682 run on x86_64-linux 1

2 packages built successfully:
  • python310Packages.zope-dottedname
  • python311Packages.zope-dottedname

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package labels Nov 11, 2023
@ofborg ofborg bot requested a review from cillianderoiste November 11, 2023 19:13
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 11, 2023
fabaff
fabaff approved these changes Nov 12, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit f5b44f3 into NixOS:master Nov 12, 2023
@natsukium natsukium deleted the zope-dottedname branch November 12, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabaff fabaff fabaff approved these changes

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@natsukium @fabaff