Skip to content

python311Packages.setuptools-trial: rename from setuptoolsTrial#266826

Merged
mweinelt merged 2 commits intoNixOS:masterfrom
natsukium:setuptools-trial
Nov 11, 2023
Merged

python311Packages.setuptools-trial: rename from setuptoolsTrial#266826
mweinelt merged 2 commits intoNixOS:masterfrom
natsukium:setuptools-trial

Conversation

@natsukium
Copy link
Copy Markdown
Member

@natsukium natsukium commented Nov 11, 2023

Description of changes

part of #245383

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 11, 2023
@natsukium natsukium mentioned this pull request Nov 11, 2023
Closed
@natsukium
Copy link
Copy Markdown
Member Author

natsukium commented Nov 11, 2023 •
edited
Loading

Result of nixpkgs-review pr 266826 at 163d14dd run on x86_64-linux 1

6 packages built successfully:
  • buildbot
  • buildbot-full
  • buildbot-ui
  • buildbot-worker
  • python310Packages.setuptools-trial
  • python311Packages.setuptools-trial

Result of nixpkgs-review pr 266826 at 163d14dd run on aarch64-darwin 1

1 package failed to build:
2 packages built successfully:
  • python310Packages.setuptools-trial
  • python311Packages.setuptools-trial

I guess buildbot-worker fails due to the darwin sandbox.

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package labels Nov 11, 2023
@ofborg ofborg bot requested a review from lopsided98 November 11, 2023 10:54
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 11, 2023
@natsukium natsukium changed the title pytho311Packages.setuptools-trial: rename from setuptoolsTrial python311Packages.setuptools-trial: rename from setuptoolsTrial Nov 11, 2023
@mweinelt mweinelt merged commit e0036cd into NixOS:master Nov 11, 2023
@natsukium natsukium deleted the setuptools-trial branch November 11, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lopsided98 lopsided98 Awaiting requested review from lopsided98

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@natsukium @mweinelt