Skip to content

cosmic-workspaces-epoch: init at unstable-2023-11-21#266720

Merged
lilyinstarlight merged 1 commit intoNixOS:masterfrom
nyabinary:cosmic-workspaces-epoch
Nov 24, 2023
Merged

cosmic-workspaces-epoch: init at unstable-2023-11-21#266720
lilyinstarlight merged 1 commit intoNixOS:masterfrom
nyabinary:cosmic-workspaces-epoch

Conversation

@nyabinary
Copy link
Copy Markdown
Contributor

@nyabinary nyabinary commented Nov 10, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@nyabinary nyabinary mentioned this pull request Nov 10, 2023
Open
33 tasks
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 10, 2023
@nyabinary nyabinary force-pushed the cosmic-workspaces-epoch branch from 6c1d95c to ef4e30b Compare November 13, 2023 16:21
@nyabinary nyabinary force-pushed the cosmic-workspaces-epoch branch from ef4e30b to ee2d939 Compare November 24, 2023 00:27
@nyabinary nyabinary changed the title cosmic-workspaces-epoch: init at unstable-2023-11-08 cosmic-workspaces-epoch: init at unstable-2023-11-21 Nov 24, 2023
lilyinstarlight
lilyinstarlight approved these changes Nov 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and it seems like it shouldn't need anything else to work. Thank you!

Will merge when ofborg finishes

@lilyinstarlight lilyinstarlight merged commit eaa523f into NixOS:master Nov 24, 2023
@nyabinary nyabinary deleted the cosmic-workspaces-epoch branch January 14, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lilyinstarlight lilyinstarlight lilyinstarlight approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nyabinary @lilyinstarlight