Skip to content

cosmic-launcher: init at unstable-2023-12-13#266716

Merged
mkg20001 merged 1 commit intoNixOS:masterfrom
nyabinary:cosmic-launcher
Jan 5, 2024
Merged

cosmic-launcher: init at unstable-2023-12-13#266716
mkg20001 merged 1 commit intoNixOS:masterfrom
nyabinary:cosmic-launcher

Conversation

@nyabinary
Copy link
Copy Markdown
Contributor

@nyabinary nyabinary commented Nov 10, 2023 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@nyabinary nyabinary mentioned this pull request Nov 10, 2023
Open
33 tasks
@alyssais
Copy link
Copy Markdown
Member

alyssais commented Nov 10, 2023 

* [ ]  Tested basic functionality of all binary files (usually in `./result/bin/`)

Have you tested that it works? You should check the box if so!

@nyabinary
Copy link
Copy Markdown
Contributor Author

nyabinary commented Nov 10, 2023 

* [ ]  Tested basic functionality of all binary files (usually in `./result/bin/`)

Have you tested that it works? You should check the box if so!

Well it runs, so I guess that basic functionality

alyssais
alyssais reviewed Nov 10, 2023
View reviewed changes
@alyssais
Copy link
Copy Markdown
Member

alyssais commented Nov 10, 2023

Since this package has some unusual stuff in it, like RUSTFLAGS, we should check it's using the right variables for cross-compilation:

@ofborg test pkgsCross.riscv64.cosmic-launcher

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 10, 2023
@nyabinary nyabinary changed the title cosmic-launcher: init at unstable-2023-11-08 cosmic-launcher: init at unstable-2023-11-21 Nov 24, 2023
@nyabinary
Copy link
Copy Markdown
Contributor Author

nyabinary commented Nov 26, 2023

Since this package has some unusual stuff in it, like RUSTFLAGS, we should check it's using the right variables for cross-compilation:

@ofborg test pkgsCross.riscv64.cosmic-launcher

Is this good to merge now?

@nyabinary nyabinary changed the title cosmic-launcher: init at unstable-2023-11-21 cosmic-launcher: init at unstable-2023-12-11 Dec 13, 2023
@nyabinary nyabinary marked this pull request as draft December 13, 2023 14:28
@nyabinary nyabinary changed the title cosmic-launcher: init at unstable-2023-12-11 cosmic-launcher: init at unstable-2023-12-13 Dec 14, 2023
@nyabinary nyabinary force-pushed the cosmic-launcher branch 3 times, most recently from f9a703d to b47da86 Compare December 26, 2023 20:12
@nyabinary nyabinary marked this pull request as ready for review January 5, 2024 15:34
mkg20001
mkg20001 reviewed Jan 5, 2024
View reviewed changes
@mkg20001 mkg20001 merged commit ad41959 into NixOS:master Jan 5, 2024
@nyabinary nyabinary deleted the cosmic-launcher branch January 14, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alyssais alyssais alyssais left review comments

@mkg20001 mkg20001 mkg20001 left review comments

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nyabinary @alyssais @mkg20001