Skip to content

xdg-desktop-portal-cosmic: init at unstable-2023-12-07#266697

Merged
lilyinstarlight merged 1 commit intoNixOS:masterfrom
nyabinary:xdg-desktop-portal-cosmic
Dec 9, 2023
Merged

xdg-desktop-portal-cosmic: init at unstable-2023-12-07#266697
lilyinstarlight merged 1 commit intoNixOS:masterfrom
nyabinary:xdg-desktop-portal-cosmic

Conversation

@nyabinary
Copy link
Copy Markdown
Contributor

Description of changes

Add xd directory & init xdg-desktop-portal-cosmic

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 10, 2023
@nyabinary nyabinary force-pushed the xdg-desktop-portal-cosmic branch from ae6998b to 39c9909 Compare December 7, 2023 23:33
@nyabinary nyabinary changed the title xdg-desktop-portal-cosmic: init at unstable-2023-10-11 xdg-desktop-portal-cosmic: init at unstable-2023-12-07 Dec 7, 2023
Copy link
Copy Markdown
Member

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to function with the one change suggested below

Thank you for working on this!

@nyabinary nyabinary force-pushed the xdg-desktop-portal-cosmic branch from 39c9909 to f6b3cb4 Compare December 8, 2023 03:51
Copy link
Copy Markdown
Member

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now, thank you!

@lilyinstarlight lilyinstarlight merged commit 8a55c06 into NixOS:master Dec 9, 2023
@nyabinary nyabinary deleted the xdg-desktop-portal-cosmic branch December 9, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants