cosmic-bg: init at unstable-2023-10-10#266687
Conversation
|
Fixed this |
9fd0a65 to
ff4ce9b
Compare
There was a problem hiding this comment.
Can we avoid using LD_LIBRARY_PATH here?
There was a problem hiding this comment.
I'm not sure avoiding it is particularly useful here (it does a dlopen at runtime)
This program won't really suffer the downsides of wrapping, and all of the other libcosmic packages need wrapping anyway
There was a problem hiding this comment.
We cannot patch the dlopen code directly?
There was a problem hiding this comment.
dlopened is used by iced/winit's wayland-dlopen feature, which is on by default, and the crate is itself a transitive dependency of cosmic-bg.
lilyinstarlight
left a comment
There was a problem hiding this comment.
The diff itself looks good to me. I'll try to do some testing when I get a chance later
OPNA2608
left a comment
There was a problem hiding this comment.
Result of nixpkgs-review pr 266687 run on x86_64-linux 1
1 package built:
- cosmic-bg
Assuming it'll work once COSMIC packaging is far enough for the desktop to be usable - running it as-is under another Wayland compositor doesn't seem to do much.
Description of changes
COSMIC bg init
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)