python311Packages.bash-kernel: rename from bash_kernel#266657
Merged
natsukium merged 2 commits intoNixOS:masterfrom Nov 12, 2023
Merged
python311Packages.bash-kernel: rename from bash_kernel#266657natsukium merged 2 commits intoNixOS:masterfrom
natsukium merged 2 commits intoNixOS:masterfrom
Conversation
Substitute the bash path more carefully, as not all quoted bash strings are meant to be paths.
Member
|
Result of 2 packages built successfully:
Result of 2 packages built successfully:
|
natsukium
approved these changes
Nov 12, 2023
Contributor
|
Hi all, I have a question here -- Is there a reason this PR removed the patch I see that some other patch was applied to the same area. (And there might have been some upstream changes there too.) But I'm experiencing a breaking with this package and I think it's because that patch was removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Part of #245383
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)