Skip to content

haskellPackages.servant-JuicyPixels: unbreak#266449

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
sorki:srk/unbreak/servant-JuicyPixels
Nov 9, 2023
Merged

haskellPackages.servant-JuicyPixels: unbreak#266449
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
sorki:srk/unbreak/servant-JuicyPixels

Conversation

@sorki
Copy link
Copy Markdown
Member

@sorki sorki commented Nov 9, 2023

Description of changes

0.3.1.1 builds again. Related to #262645

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Nov 9, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 9, 2023
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hydraPlatforms = lib.platforms.none;

You also need to remove hydraPlatforms = none, otherwise Hydra won't build it and it won't end up in the cache!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I don't appear to be able to auto-commit this through the GitHub UI for some reason...

@sorki Could you commit this change as well?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Good to know and thanks!

@sorki sorki force-pushed the srk/unbreak/servant-JuicyPixels branch from 3dc8e97 to 704a2b7 Compare November 9, 2023 13:32
@cdepillabout
Copy link
Copy Markdown
Member

@ofborg build haskellPackages.servant-JuicyPixels

@cdepillabout
Copy link
Copy Markdown
Member

Built on ofborg on Linux, LGTM! Thanks!

@cdepillabout cdepillabout merged commit 2d76106 into NixOS:haskell-updates Nov 9, 2023
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants