cosmic-session: init at 0-unstable-2024-01-17#266339
Merged
lilyinstarlight merged 1 commit intoNixOS:masterfrom Jan 18, 2024
Merged
cosmic-session: init at 0-unstable-2024-01-17#266339lilyinstarlight merged 1 commit intoNixOS:masterfrom
lilyinstarlight merged 1 commit intoNixOS:masterfrom
Conversation
95e78c1 to
14aca6d
Compare
33 tasks
Member
Author
|
Result of 1 package built:
|
nyabinary
approved these changes
Nov 10, 2023
14aca6d to
1aa6155
Compare
nyabinary
reviewed
Dec 3, 2023
Contributor
nyabinary
left a comment
There was a problem hiding this comment.
Needs updating to the latest commit :)
Member
Author
Is |
man0lis
suggested changes
Dec 5, 2023
d3aec31 to
9049628
Compare
Contributor
|
pop-os/cosmic-session@b5cd1a8 |
Member
Author
|
Thanks @nyabinary |
9049628 to
6f198e0
Compare
nbdd0121
suggested changes
Dec 24, 2023
Member
nbdd0121
left a comment
There was a problem hiding this comment.
This needs an extra
postInstall = ''
substituteInPlace $out/share/wayland-sessions/cosmic.desktop --replace '/usr/bin/start-cosmic' "$out/bin/start-cosmic"
'';to replace the hardcoded path in share/wayland-sessions/cosmic.desktop.
9e73337 to
064bdc0
Compare
Member
lilyinstarlight
left a comment
There was a problem hiding this comment.
Looks pretty much good, thank you for your work on this!
I've left a few nits that could make it a bit clearer/follow convention better, but otherwise this looks fabulous
Contributor
|
Also need to update the versioning scheme to put a 0- at the front of the name and update the commit to the latest version :3 |
cb8e344 to
3da201d
Compare
Member
Author
|
Thank you for the review @lilyinstarlight ! |
nyabinary
reviewed
Jan 14, 2024
002134d to
4fe2739
Compare
lilyinstarlight
approved these changes
Jan 16, 2024
Member
lilyinstarlight
left a comment
There was a problem hiding this comment.
Looks good to me, thank you! I will merge when ofborg is green
Contributor
|
new commit dropped: pop-os/cosmic-session@334aebc |
0fcda9f to
6f61987
Compare
6f61987 to
7d758e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Needs a module to function properly.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)