Skip to content

libaom: fix cross#266257

Merged
Artturin merged 1 commit intomasterfrom
unknown repository
Nov 19, 2023
Merged

libaom: fix cross#266257
Artturin merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Nov 8, 2023

Description of changes

Apparently the CMake variable for indicating the assembler has changed from AS_EXECUTABLE to CMAKE_ASM_COMPILER.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

libaom: fix cross
10bc6bc 
Apparently the CMake variable for indicating the assembler has
changed from `AS_EXECUTABLE` to `CMAKE_ASM_COMPILER`.
@ghost ghost marked this pull request as ready for review November 8, 2023 12:10
@ofborg ofborg bot added 6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 8, 2023
@NickCao
Copy link
Copy Markdown
Member

NickCao commented Nov 8, 2023

@ofborg build pkgsCross.aarch64-multiplatform.libaom

@Artturin
Copy link
Copy Markdown
Member

Artturin commented Nov 8, 2023 •
edited
Loading

CI failed

CMake Error at build/cmake/aom_configure.cmake:192 (message):
  Unable to find assembler and optimizations are enabled.Searched for as.
  Install it, add it to your path, or set the assembler directly by adding
  -DAS_EXECUTABLE=<assembler path> to your CMake command line.To build
  without optimizations, add -DAOM_TARGET_CPU=generic to your cmake command
  line.
Call Stack (most recent call first):
  CMakeLists.txt:66 (include)

pkgsCross.aarch64-multiplatform.libaom builds on master

@ghost ghost marked this pull request as draft November 9, 2023 01:06
@uninsane
Copy link
Copy Markdown
Contributor

uninsane commented Nov 19, 2023

pkgsCross.aarch64-multiplatform.libaom does not build from x86_64 for me on master (653e323). this patch fixes it.

@Artturin
Copy link
Copy Markdown
Member

Artturin commented Nov 19, 2023

That's true, dunno what happened.

@Artturin Artturin marked this pull request as ready for review November 19, 2023 00:21
@Artturin Artturin merged commit cc27610 into NixOS:master Nov 19, 2023
@ghost ghost deleted the pr/libaom/fixcross branch January 23, 2024 06:48
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NickCao @Artturin @uninsane