skalibs: fix cross#266253
Merged
Conversation
alyssais
reviewed
Nov 8, 2023
Member
|
@ofborg build pkgsCross.riscv64.skalibs |
alyssais
approved these changes
Nov 8, 2023
Member
alyssais
left a comment
There was a problem hiding this comment.
LGTM with a squash as long as OfBorg ends up being happy.
skalibs-2.14.0.0 added detection for some weird bug exhibited in "old glibcs and some virtual platforms". When cross compiling the detector cannot be run: > posixspawnearlyreturn: `yes` if the target has a broken > `posix_spawn()` implementation that can return before the > child has successfully exec'ed. That happens with old glibcs > and some virtual platforms. I just took a wild guess here and picked `no`. Co-authored-by: Alyssa Ross <hi@alyssa.is>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
skalibs-2.14.0.0 added detection for some weird bug exhibited in "old glibcs and some virtual platforms". When cross compiling the detector cannot be run:
I just took a wild guess here and picked
no.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)