cosmic-greeter: init at unstable-2023-11-08#266138
Merged
lilyinstarlight merged 1 commit intoNixOS:masterfrom Nov 9, 2023
Merged
cosmic-greeter: init at unstable-2023-11-08#266138lilyinstarlight merged 1 commit intoNixOS:masterfrom
lilyinstarlight merged 1 commit intoNixOS:masterfrom
Conversation
Member
|
Result of 1 package built:
|
Member
lilyinstarlight
left a comment
There was a problem hiding this comment.
This looks good! I left a few minor nits for seemingly unused stuff, but otherwise this looks merge-ready
2cf4aa9 to
44267aa
Compare
lilyinstarlight
approved these changes
Nov 9, 2023
Member
lilyinstarlight
left a comment
There was a problem hiding this comment.
The diff looks good to me now! Once the ofborg eval+builds all succeed, then I'll go ahead and merge, thanks!
33 tasks
Contributor
|
How to use it? the following does not work: {pkgs, ...}:
{
services.greetd = {
enable = true;
pkgs.cosmic-greeter;
};
}
`` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)