gcc: move version iteration out of all-packages.nix#265934
Merged
3 commits merged intomasterfrom Nov 7, 2023
unknown repository
Merged
gcc: move version iteration out of all-packages.nix#2659343 commits merged intomasterfrom unknown repository
3 commits merged intomasterfrom
unknown repository
Conversation
added 2 commits
November 6, 2023 14:00
This resolves a TODO previously in all-packages.nix.
13 tasks
Mindavi
approved these changes
Nov 7, 2023
Contributor
Mindavi
left a comment
There was a problem hiding this comment.
I like this conceptually. Less things in all-packages is good
Author
|
Normally I would not merge changes to gcc at this point in the release cycle, but this one has no effect on eval. It will also make it easier to backport any changes that happen after branch-off if necessary. |
13 tasks
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR causes zero rebuilds and does not affect eval.
It simply moves a bunch of gcc-specific logic out of
all-packages.nixand intopkgs/compilers/gcc.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)This resolves a TODO previously in all-packages.nix.