Skip to content

Init haystack#265845

Merged
happysalada merged 2 commits intoNixOS:masterfrom
happysalada:init_haystack
Nov 8, 2023
Merged

Init haystack#265845
happysalada merged 2 commits intoNixOS:masterfrom
happysalada:init_haystack

Conversation

@happysalada
Copy link
Copy Markdown
Contributor

@happysalada happysalada commented Nov 6, 2023 •
edited
Loading

Description of changes

This is still a little rough, I'm opening this early for feedback/ help.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 6, 2023
@happysalada happysalada requested a review from natsukium November 6, 2023 12:34
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 6, 2023
natsukium
natsukium reviewed Nov 7, 2023
View reviewed changes
@happysalada
Copy link
Copy Markdown
Contributor Author

happysalada commented Nov 7, 2023

@natsukium thank you for the review, I've made the changes.
What I found weird was mostly around the optional dependencies containing the package itself, the rest should hopefully be fine.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 7, 2023
@natsukium
Copy link
Copy Markdown
Member

natsukium commented Nov 8, 2023

The excessive aliases might be necessary for development.

@happysalada happysalada merged commit e556bb0 into NixOS:master Nov 8, 2023
@happysalada happysalada deleted the init_haystack branch November 8, 2023 09:57
@Stunkymonkey Stunkymonkey mentioned this pull request Jan 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natsukium natsukium natsukium left review comments

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@happysalada @natsukium @delroth