Skip to content

bcachefs-tools: unstable-2023-06-28 -> 1.3.1#265820

Merged
thoughtpolice merged 1 commit intomasterfrom
unknown repository
Nov 15, 2023
Merged

bcachefs-tools: unstable-2023-06-28 -> 1.3.1#265820
thoughtpolice merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Nov 6, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ghost ghost marked this pull request as ready for review November 6, 2023 09:11
@ghost ghost changed the title bcachefs-tools: unstable-2023-09-29 -> 1.3.1 bcachefs-tools: unstable-2023-06-28 -> 1.3.1 Nov 6, 2023
@ghost
Copy link
Copy Markdown
Author

ghost commented Nov 6, 2023

@ofborg build bcachefs-tools

@ofborg ofborg bot requested review from Madouura and davidak November 6, 2023 10:23
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 6, 2023
@ghost
Copy link
Copy Markdown
Author

ghost commented Nov 7, 2023

We should probably consider updating our linux_testing_bcachefs at some point soon... I had some really bad experiences with our patches-on-linux-6.4-based bcachefs. Using the upstream nightly (6.7 prerelease) fixed them.

Copy link
Copy Markdown
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm running testing and would like to use this, so +1

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 15, 2023
@thoughtpolice
Copy link
Copy Markdown
Member

thoughtpolice commented Nov 15, 2023

We should probably consider updating our linux_testing_bcachefs at some point soon... I had some really bad experiences with our patches-on-linux-6.4-based bcachefs. Using the upstream nightly (6.7 prerelease) fixed them.

Why even keep linux_testing_bcachefs around at this point, now that bcachefs is in 6.7-rc1? Nevermind, I missed #267640! Sorry. We can just merge this. :)

@thoughtpolice thoughtpolice merged commit 372ce96 into NixOS:master Nov 15, 2023
@vcunat
Copy link
Copy Markdown
Member

vcunat commented Nov 16, 2023

This conflicted with PR #256638. Perhaps you want to check the result in 0fe5300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants