Skip to content

python311Packages.vega-datasets: rename from vega_datasets#265390

Merged
natsukium merged 2 commits intoNixOS:masterfrom
natsukium:vega-datasets
Nov 5, 2023
Merged

python311Packages.vega-datasets: rename from vega_datasets#265390
natsukium merged 2 commits intoNixOS:masterfrom
natsukium:vega-datasets

Conversation

@natsukium
Copy link
Copy Markdown
Member

@natsukium natsukium commented Nov 4, 2023

Description of changes

part of #245383

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 4, 2023
@natsukium natsukium mentioned this pull request Nov 4, 2023
Closed
@natsukium
Copy link
Copy Markdown
Member Author

natsukium commented Nov 4, 2023

Result of nixpkgs-review pr 265390 at 9d3c9da run on aarch64-darwin 1

4 packages failed to build:
8 packages built successfully:
  • python310Packages.altair
  • python310Packages.streamlit
  • python310Packages.vega
  • python310Packages.vega-datasets
  • python311Packages.altair
  • streamlit (python311Packages.streamlit)
  • python311Packages.vega
  • python311Packages.vega-datasets

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package labels Nov 4, 2023
@ofborg ofborg bot requested review from Vinetos, pbsds and teh November 4, 2023 05:40
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Nov 4, 2023
Vinetos
Vinetos approved these changes Nov 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Vinetos Vinetos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 4, 2023
@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Nov 4, 2023
@natsukium natsukium merged commit e1a2239 into NixOS:master Nov 5, 2023
@natsukium natsukium deleted the vega-datasets branch November 5, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbsds pbsds pbsds approved these changes

@teh teh Awaiting requested review from teh

+1 more reviewer

@Vinetos Vinetos Vinetos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@natsukium @pbsds @Vinetos @delroth