cosmic-edit: init at unstable-2023-11-02#265103
Merged
alyssais merged 2 commits intoNixOS:masterfrom Nov 7, 2023
ahoneybun:cosmic-edit
Merged
cosmic-edit: init at unstable-2023-11-02#265103alyssais merged 2 commits intoNixOS:masterfrom ahoneybun:cosmic-edit
alyssais merged 2 commits intoNixOS:masterfrom
ahoneybun:cosmic-edit
Conversation
Member
|
Please split adding yourself as a maintainer into as separate commit, as the |
Lurkki14
suggested changes
Nov 3, 2023
Contributor
Author
It fails if I don't do it now though. Feel free to drop it if needed though. |
Member
|
You need to squash your commits, so one commit for adding yourself to the maintainer list, and one for adding the package. |
Member
|
And the commit that adds yourself as a maintainer needs to be prior to adding the package. |
Member
|
The commit message for adding yourself to maintainers should be |
Lurkki14
approved these changes
Nov 7, 2023
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
COSMIC Edit is the Text Editor for the COSMIC DE:
https://github.com/pop-os/cosmic-edit
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)