Skip to content

CODEOWNERS: add ckiee to libconfig format#264638

Merged
infinisil merged 1 commit intoNixOS:masterfrom
ckiee:codeowners-add-libconfig
Oct 31, 2023
Merged

CODEOWNERS: add ckiee to libconfig format#264638
infinisil merged 1 commit intoNixOS:masterfrom
ckiee:codeowners-add-libconfig

Conversation

@ckiee
Copy link
Copy Markdown
Member

@ckiee ckiee commented Oct 31, 2023

Description of changes

as requested by #264581 (comment)
@h7x4 is missing the committer bit, so this is marked WIP.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: policy discussion Discuss policies to work in and around Nixpkgs label Oct 31, 2023
@infinisil
Copy link
Copy Markdown
Member

Just you @ckiee also sounds fine to me, getting @h7x4 commit access should be orthogonal (as should GitHub allowing code owners without commit access :))

@h7x4
Copy link
Copy Markdown
Member

h7x4 commented Oct 31, 2023

Setting just @ckiee for now seems fine with me. I'll probably act as codeowner in spirit anyway.

@ckiee ckiee changed the title CODEOWNERS: add ckie and h7x4 to libconfig format CODEOWNERS: add ckiee to libconfig format Oct 31, 2023
@ckiee ckiee force-pushed the codeowners-add-libconfig branch from d1c4552 to 3eaa06f Compare October 31, 2023 19:12
@ckiee ckiee marked this pull request as ready for review October 31, 2023 19:12
@ckiee ckiee requested a review from edolstra as a code owner October 31, 2023 19:12
@ckiee
Copy link
Copy Markdown
Member Author

ckiee commented Oct 31, 2023

@infinisil merge?

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 31, 2023
@infinisil infinisil merged commit b22c7cc into NixOS:master Oct 31, 2023
@infinisil
Copy link
Copy Markdown
Member

Merge!

@h7x4 h7x4 mentioned this pull request Jan 22, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: policy discussion Discuss policies to work in and around Nixpkgs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants