Skip to content

apr-util: find correct BDB when using clang 16#264246

Merged
K900 merged 1 commit intoNixOS:staging-nextfrom
reckenrode:apr-util-fix
Nov 1, 2023
Merged

apr-util: find correct BDB when using clang 16#264246
K900 merged 1 commit intoNixOS:staging-nextfrom
reckenrode:apr-util-fix

Conversation

@reckenrode
Copy link
Copy Markdown
Contributor

Description of changes

Fix an implicit int in dbm.m4 that causes the configure script to fail to find the correct Berkeley DB version (resulting in Subversion’s failing to build with clang 16).

This fixes the subversion build failure on Darwin in staging-next. #263535

https://hydra.nixos.org/build/239486210
https://hydra.nixos.org/build/239632728

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Fix an implicit `int` in `dbm.m4` that causes the `configure` script to
fail to find the correct Berkeley DB version (resulting in Subversion’s
failing to build with clang 16).
@ofborg ofborg bot requested a review from edolstra October 29, 2023 23:11
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Oct 29, 2023
@K900 K900 merged commit 866435f into NixOS:staging-next Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants