Skip to content

cosmic-icons: init at unstable-2023-08-30#264225

Merged
alyssais merged 1 commit intoNixOS:masterfrom
a-kenji:init/cosmic-icons
Nov 1, 2023
Merged

cosmic-icons: init at unstable-2023-08-30#264225
alyssais merged 1 commit intoNixOS:masterfrom
a-kenji:init/cosmic-icons

Conversation

@a-kenji
Copy link
Copy Markdown
Member

@a-kenji a-kenji commented Oct 29, 2023 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@nyabinary nyabinary mentioned this pull request Oct 29, 2023
Merged
13 tasks
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 29, 2023
@natsukium
Copy link
Copy Markdown
Member

natsukium commented Oct 30, 2023

@ofborg eval

K900
K900 reviewed Oct 31, 2023
View reviewed changes
@alyssais alyssais self-requested a review October 31, 2023 14:56
alyssais
alyssais reviewed Oct 31, 2023
View reviewed changes
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 31, 2023
@nyabinary nyabinary self-requested a review November 1, 2023 18:10
nyabinary
nyabinary approved these changes Nov 1, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@nyabinary nyabinary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Nov 1, 2023
@alyssais alyssais merged commit da939a8 into NixOS:master Nov 1, 2023
@a-kenji a-kenji deleted the init/cosmic-icons branch November 1, 2023 19:09
@a-kenji
Copy link
Copy Markdown
Member Author

a-kenji commented Nov 1, 2023

Thanks for the help and reviews!

@nyabinary nyabinary mentioned this pull request Nov 2, 2023
Open
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@K900 K900 K900 left review comments

@alyssais alyssais alyssais approved these changes

+1 more reviewer

@nyabinary nyabinary nyabinary approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@a-kenji @natsukium @K900 @alyssais @nyabinary @delroth