Closed
Conversation
13 tasks
13 tasks
Contributor
Author
|
I unfortunately have no time to finish this. 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR retires
systemdMinimal. It's a follow-up to #261798. The goal is to avoid having multiple sets of systemd binaries in a typical system closure and save everyone some disk space. This is especially relevant for smaller image-based systems (see #263462).We replace
systemdMinimalwith:systemd, if systemd commands orudevadmis needed (bluez) or whensystemdis already in the closure (dbus)systemdLibssystemditself to break dependencieslibudevorlibsystemdthat don't already havesystemdin their closure.Some of the uses of
systemdLibscould just besystemd, if we manage to givepkgs.systemdaliboutput that doesn't drag in lots of unneeded binaries.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)