Skip to content

[Backport release-23.05] build-fhsenv-bubblewrap: remove /usr/lib and /usr/lib32 from LD_LIBRARY_PATH#263378

Merged
mweinelt merged 1 commit intorelease-23.05from
backport-263201-to-release-23.05
Nov 7, 2023
Merged

[Backport release-23.05] build-fhsenv-bubblewrap: remove /usr/lib and /usr/lib32 from LD_LIBRARY_PATH#263378
mweinelt merged 1 commit intorelease-23.05from
backport-263201-to-release-23.05

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Bot-based backport to release-23.05, triggered by a label in #263201.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Oct 25, 2023
@poelzi
Copy link
Copy Markdown
Member

poelzi commented Nov 6, 2023

@SuperSandro2000 can you merge ?

@LunNova
Copy link
Copy Markdown
Member

LunNova commented Nov 6, 2023

I'm personally not confident enough that this is safe for a release backport to approve, especially given that I'd be approving my own diff from the other PR.

While I'm not aware of any reported issues with the change in nixos-unstable it does have a potentially significant impact on library selection inside apps using fhs envs so I'm a bit nervous.

@LunNova
Copy link
Copy Markdown
Member

LunNova commented Nov 6, 2023

#265476 - an example of a regression due to this change

Maybe we still want to backport as #262080 is really annoying but I don't think I'm the right person to make a decision like that.

@LunNova
Copy link
Copy Markdown
Member

LunNova commented Nov 6, 2023

cc release managers @RaitoBezarius @mweinelt

@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Nov 6, 2023

It's hard for me to understand the impact of that change.

@Atemu
Copy link
Copy Markdown
Member

Atemu commented Nov 7, 2023

It fixes a breaking regression: #262080

I too am uncomfortable but applications should generally not require /lib in LD_LIBRARY_PATH (they should require nothing in it). The one I thought might need it (steam) doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants