[Backport release-23.05] build-fhsenv-bubblewrap: remove /usr/lib and /usr/lib32 from LD_LIBRARY_PATH#263378
Merged
mweinelt merged 1 commit intorelease-23.05from Nov 7, 2023
Merged
Conversation
13 tasks
poelzi
approved these changes
Nov 6, 2023
Member
|
@SuperSandro2000 can you merge ? |
Member
|
I'm personally not confident enough that this is safe for a release backport to approve, especially given that I'd be approving my own diff from the other PR. While I'm not aware of any reported issues with the change in nixos-unstable it does have a potentially significant impact on library selection inside apps using fhs envs so I'm a bit nervous. |
Member
Member
|
cc release managers @RaitoBezarius @mweinelt |
Member
|
It's hard for me to understand the impact of that change. |
Member
|
It fixes a breaking regression: #262080 I too am uncomfortable but applications should generally not require /lib in LD_LIBRARY_PATH (they should require nothing in it). The one I thought might need it (steam) doesn't. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-23.05, triggered by a label in #263201.