Merged
Conversation
It now also checks the executable bit.
12 tasks
Mic92
approved these changes
Oct 24, 2023
Member
Mic92
left a comment
There was a problem hiding this comment.
First I was concerned this wouldn't pretty print formats, but it does. So looks good to me.
Member
|
|
Lassulus
approved these changes
Oct 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
These functions appear to have been added by mistake.
This change is the bare minimum to reduce maintenance.
Whether to further deprecate or document the aliases is still to be decided.
See #244835 (review) and subsequent comments.
makeDataWriter; not used in Nixpkgs and neither specific enough nor general enoughThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)