Skip to content

tests.cross.sanity: add pkgs.pkgsMusl.pkgsCross.gnu64.hello#262876

Merged
Artturin merged 2 commits intomasterfrom
unknown repository
Nov 3, 2023
Merged

tests.cross.sanity: add pkgs.pkgsMusl.pkgsCross.gnu64.hello#262876
Artturin merged 2 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Oct 23, 2023

Description of changes

Adds a useful case to tests.cross.sanity

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Oct 23, 2023
@ghost ghost requested a review from alyssais October 23, 2023 08:09
@ghost ghost marked this pull request as ready for review October 23, 2023 08:09
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 23, 2023
@alyssais
Copy link
Copy Markdown
Member

This is currently only expected to work on x86_64-linux — is there a way to encode that? (I'm not familiar with these tests, so maybe that's already how it works. Apologies if so.)

@ghost
Copy link
Copy Markdown
Author

ghost commented Oct 26, 2023

This is currently only expected to work on x86_64-linux — is there a way to encode that?

Good point! See ec15933.

Note that Hydra does not run these tests yet.

@Artturin Artturin merged commit 297a971 into NixOS:master Nov 3, 2023
@ghost ghost deleted the pr/cross-sanity-musl branch November 3, 2023 06:24
@cafkafk cafkafk mentioned this pull request Nov 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants