spandsp: fix function argument name (typo)#262842
Merged
1 commit merged intomasterfrom Dec 1, 2023
unknown repository
Merged
Conversation
The function here is being passed to `overrideAttrs`, not `mkDerivation`, so it should be named `previousAttrs`, not `finalAttrs`. This was my mistake.
Author
|
This is just a stylistic fix, changing the name of a lambda-bound variable to be less confusing. Since it is trivial I will self-merge it without a review. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The function here is being passed to
overrideAttrs, notmkDerivation, so it should be namedpreviousAttrs, notfinalAttrs. This was my mistake.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)