Skip to content

gtk2: fix build with clang 16#262825

Merged
7c6f434c merged 1 commit intoNixOS:masterfrom
reckenrode:gtk2-fix
Oct 23, 2023
Merged

gtk2: fix build with clang 16#262825
7c6f434c merged 1 commit intoNixOS:masterfrom
reckenrode:gtk2-fix

Conversation

@reckenrode
Copy link
Copy Markdown
Contributor

Description of changes

  • Resolve incompatible function pointer conversion error; and
  • Fix signature of create_menu in tests/testmenubars.c.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

* Resolve incompatible function pointer conversion error; and
* Fix signature of `create_menu` in `tests/testmenubars.c`.
@ofborg ofborg bot requested review from 7c6f434c and lovek323 October 23, 2023 01:03
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 23, 2023
@7c6f434c 7c6f434c merged commit 418666f into NixOS:master Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants