Skip to content

libshout: fix build with clang 16#262820

Merged
wegank merged 1 commit intoNixOS:staging-nextfrom
reckenrode:libshout-fix
Oct 27, 2023
Merged

libshout: fix build with clang 16#262820
wegank merged 1 commit intoNixOS:staging-nextfrom
reckenrode:libshout-fix

Conversation

@reckenrode
Copy link
Copy Markdown
Contributor

@reckenrode reckenrode commented Oct 22, 2023

Description of changes

  • Upstream MR includes several missing headers that were resulting in implicit function declaration errors.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@reckenrode
libshout: fix build with clang 16
34c88b1 
* Upstream MR includes several missing headers that were resulting in
  implicit function declaration errors.
@reckenrode reckenrode mentioned this pull request Oct 22, 2023
Closed
@ofborg ofborg bot requested a review from jcumming October 23, 2023 00:11
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Oct 23, 2023
@reckenrode
Copy link
Copy Markdown
Contributor Author

reckenrode commented Oct 27, 2023 •
edited
Loading

This is failing on staging-next: https://hydra.nixos.org/build/239449199. #263535

@reckenrode reckenrode changed the base branch from master to staging-next October 27, 2023 12:46
@reckenrode
Copy link
Copy Markdown
Contributor Author

reckenrode commented Oct 27, 2023

Targeting staging-next due to the number of rebuilds.

@wegank wegank merged commit fd36865 into NixOS:staging-next Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcumming jcumming Awaiting requested review from jcumming

Assignees

No one assigned

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reckenrode @wegank