Skip to content

python3Packages.kivy: fix build on Darwin#262816

Merged
wegank merged 1 commit intoNixOS:masterfrom
reckenrode:kivy-fix
Oct 23, 2023
Merged

python3Packages.kivy: fix build on Darwin#262816
wegank merged 1 commit intoNixOS:masterfrom
reckenrode:kivy-fix

Conversation

@reckenrode
Copy link
Copy Markdown
Contributor

Description of changes

  • Add the Accelerate framework as a buildInput; and
  • Fix incompatible function pointer conversion errors with clang 16.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 22, 2023
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 22, 2023
@ofborg ofborg bot requested a review from rissson October 22, 2023 23:51
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 22, 2023
* Add the Accelerate framework as a `buildInput`; and
* Fix incompatible function pointer conversion errors with clang 16.

Co-authored-by: Weijia Wang <9713184+wegank@users.noreply.github.com>
@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 23, 2023
@wegank
Copy link
Copy Markdown
Member

wegank commented Oct 23, 2023

Result of nixpkgs-review pr 262816 run on aarch64-darwin 1

8 packages built:
  • nsz (python311Packages.nsz)
  • nsz.dist (python311Packages.nsz.dist)
  • python310Packages.kivy
  • python310Packages.kivy.dist
  • python310Packages.nsz
  • python310Packages.nsz.dist
  • python311Packages.kivy
  • python311Packages.kivy.dist

@wegank wegank merged commit eae5987 into NixOS:master Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants