Merged
Conversation
* Include required frameworks; and * Use gettext from nixpkgs (required for building with newer clangs).
dotlambda
reviewed
Oct 25, 2025
|
|
||
| # Darwin needs to link against gettext from nixpkgs instead of the one vendored by gettext-sys | ||
| # because the vendored copy does not build with newer versions of clang. | ||
| env = lib.optionalAttrs stdenv.isDarwin { |
Member
There was a problem hiding this comment.
What's the reason we only do this on Darwin? Isn't it preferred to unvendor gettext everywhere?
Member
There was a problem hiding this comment.
Never mind, this should already be the case on Linux due to features = ["gettext-system"] in Cargo.toml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)