crystal: fix build with newer versions of clang#262659
Conversation
|
Are you able to test if there is any issues as a consequence of the llvm build on nixos too? |
Crystal requires linking libc++abi when building with newer versions of clang. See NixOS#166205.
f514958 to
2ce46f4
Compare
It shouldn’t affect standard Linux. I reworked the patch to check for clang and libc++, so it should work with |
|
This is failing on staging-next: https://hydra.nixos.org/build/239425775. #263535 |
toonn
left a comment
There was a problem hiding this comment.
LGTM
When rebased on staging-next the commit indeed fixes the crystal build.
On master the commit also builds, but, when editing the crystal derivation to use llvmPackages_16.stdenv (because crystal is not overridable) a segmentation fault occurs when running the built crystal compiler (this happens during the build). On master without the commit, but, changing the derivation to use LLVM 16 stdenv the segmentation fault does not happen and instead the same error as on staging-next happens.
Since staging-next will soon be merged into master and building crystal with a different stdenv is not straightforward anyway I'm going ahead with merging this.
Description of changes
Crystal requires linking libc++abi when building with newer versions of clang. See #166205.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)