darwin.Libm: add missing function declarations#262567
Merged
wegank merged 4 commits intoNixOS:stagingfrom Oct 21, 2023
Merged
Conversation
The patch in this commit is based on the SDK header, which has an ASPL license header even though the updated header is not part of the source distribution of Libm. Adding the missing declarations allows packages such as jq, Ruby, and Guile to build without requiring an SDK that is not built from the source releases.
This reverts commit 9458958.
This reverts commit 98bd317.
This reverts commit f838258.
wegank
approved these changes
Oct 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The patch in this commit is based on the SDK header, which has an ASPL license header even though the updated header is not part of the source distribution of Libm. Adding the missing declarations allows packages such as jq, Ruby, and Guile to build without requiring an SDK that is not built from the source releases.
This PR reverts the changes made to Ruby and Guile to build them against the 11.0 SDK because it is no longer necessary.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)