Skip to content

treewide: remove execute bit for non-executable *.nix files#262351

Merged
veprbl merged 1 commit intoNixOS:masterfrom
h7x4:remove-nix-exec-bits
Oct 20, 2023
Merged

treewide: remove execute bit for non-executable *.nix files#262351
veprbl merged 1 commit intoNixOS:masterfrom
h7x4:remove-nix-exec-bits

Conversation

@h7x4
Copy link
Copy Markdown
Member

@h7x4 h7x4 commented Oct 20, 2023

Description of changes

Removed the execute bit for a bunch of files that had no business being marked as executable.

No packages were harmed in the creation of this PR:

Result of nixpkgs-review run on x86_64-linux 1

1 package blacklisted:
  • nixos-install-tools

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: vim Advanced text editor labels Oct 20, 2023
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 20, 2023
@veprbl veprbl merged commit 6392f18 into NixOS:master Oct 20, 2023
@h7x4 h7x4 deleted the remove-nix-exec-bits branch November 9, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: vim Advanced text editor 8.has: module (update) This PR changes an existing module in `nixos/` 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants