haskell.compiler.ghc*Binary: fix globbing#260410
Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom Oct 22, 2023
Merged
haskell.compiler.ghc*Binary: fix globbing#260410maralorn merged 1 commit intoNixOS:haskell-updatesfrom
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
12 tasks
sternenseemann
approved these changes
Oct 13, 2023
sternenseemann
requested changes
Oct 15, 2023
Member
sternenseemann
left a comment
There was a problem hiding this comment.
We actually need to check for
"$out"/lib/ghc-*/lib/package.conf.d(hadrian) and"$out"/lib/ghc-*/package.conf.d(make)
and use whichever exists, since there is a mix between what was used to build the bindists here.
8ba4357 to
082a03e
Compare
sternenseemann
approved these changes
Oct 16, 2023
Member
|
Interesting that we have hadrian bindists in the earlier binary GHCs, but none of the hadrian specific of the 9.2.4 one. A mystery to ponder some other time… Thanks! Probably makes sense to merge this big rebuild the next iteration around. |
Member
|
Am I correct in assuming that we merge this the next time we want to do a full set rebuild? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the
--package-db="$out/lib/"ghc-*/package.conf.dglob (this does not do what you think!).Disable
nullglobas it seems incompatible with the way globs are used throughout those files, and caused some errors to be silently ignored.