Skip to content

python311Packages.deep_merge: remove#259944

Merged
NickCao merged 2 commits intoNixOS:masterfrom
natsukium:deep_merge/drop
Oct 9, 2023
Merged

python311Packages.deep_merge: remove#259944
NickCao merged 2 commits intoNixOS:masterfrom
natsukium:deep_merge/drop

Conversation

@natsukium
Copy link
Copy Markdown
Member

Description of changes

part of #245383

deep_merge was introduced as a dependency for checkov, but it has not been maintained for over 5 years and checkov has removed it in this PR.
bridgecrewio/checkov#5605

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

It is no longer maintained and is not needed for other packages.
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 9, 2023
@natsukium
Copy link
Copy Markdown
Member Author

Result of nixpkgs-review pr 259944 run on x86_64-linux 1

2 packages built:
  • checkov
  • checkov.dist

@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Oct 9, 2023
@ofborg ofborg bot requested review from anhdle14 and fabaff October 9, 2023 09:38
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 9, 2023
@NickCao NickCao merged commit 2c53f43 into NixOS:master Oct 9, 2023
@natsukium natsukium deleted the deep_merge/drop branch October 9, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants