mjpegtools: fix build with clang 16#259869
Merged
toonn merged 1 commit intoNixOS:stagingfrom Oct 11, 2023
Merged
Conversation
Contributor
Did you mean clang 16? That's what the comment says. |
Contributor
Author
That’s a typo. I’ll fix the commit message. |
Clang 16 defaults to C++17, causing the build to fail because the following has been removed from C++17: * `std::auto_ptr`; and * The `register` type class specifier.
339a036 to
9622ba4
Compare
toonn
approved these changes
Oct 11, 2023
Contributor
toonn
left a comment
There was a problem hiding this comment.
LGTM, fixes building with Clang 16 on both Linux and Darwin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Clang 16 defaults to C++17, causing the build to fail because the following has been removed from C++17:
std::auto_ptr; andregistertype class specifier.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)