audiofile: fix build with clang 16#259300
Merged
toonn merged 1 commit intoNixOS:stagingfrom Oct 14, 2023
Merged
Conversation
4f1f4ef to
4f2bb1c
Compare
toonn
reviewed
Oct 13, 2023
Contributor
toonn
left a comment
There was a problem hiding this comment.
Fixes the issue on x86_64-darwin. However, I can't reproduce the failure on x86_64-linux.
Any idea why that might be? I would assume Clang 16 on Linux still defaults to C++17?
toonn
approved these changes
Oct 14, 2023
Contributor
toonn
left a comment
There was a problem hiding this comment.
LGTM
The lack of failure on x86_64-linux without these fixes is due to libstdc++ opting to implement those classes for ABI stability apparently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
std::unary_functionis removed in c++17This breaks building with clang 16. (#234710)
Things done
Set the
-stdto a lower one.sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)