rust.toRustTargetForUseInEnvVars: support custom targets#257411
Merged
alyssais merged 1 commit intoNixOS:staging-nextfrom Oct 3, 2023
Merged
rust.toRustTargetForUseInEnvVars: support custom targets#257411alyssais merged 1 commit intoNixOS:staging-nextfrom
alyssais merged 1 commit intoNixOS:staging-nextfrom
Conversation
> If using a target spec JSON file, the <triple> value is the filename > stem. For example --target foo/bar.json would match [target.bar]. - https://doc.rust-lang.org/cargo/reference/config.html#target I've also exposed toRustTargetSpecShort as a public function, because it's useful to be able to know what the target subdirectory will be.
RaitoBezarius
approved these changes
Oct 3, 2023
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
- https://doc.rust-lang.org/cargo/reference/config.html#target
I've also exposed
toRustTargetSpecShortas a public function, because it's useful to be able to know what the target subdirectory will be.I think this is a minor regression in #247442. As these things go, I noticed just after merging it. >.>
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)