Skip to content

postgresql: default to v15 in 23.11#254268

Merged
yu-re-ka merged 1 commit intoNixOS:stagingfrom
nbdd0121:postgres-state-version
Sep 27, 2023
Merged

postgresql: default to v15 in 23.11#254268
yu-re-ka merged 1 commit intoNixOS:stagingfrom
nbdd0121:postgres-state-version

Conversation

@nbdd0121
Copy link
Copy Markdown
Member

@nbdd0121 nbdd0121 commented Sep 9, 2023

Description of changes

Change the default postgres version from 14 to 15 in release 23.11.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 9, 2023
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Sep 9, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 9, 2023
thoughtpolice
thoughtpolice requested changes Sep 9, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@thoughtpolice thoughtpolice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs a change in all-packages.nix to change the default postgresql and postgresqlPackages expressions.

EDIT: Specifically, look here — https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/all-packages.nix#L27276-L27289

Please swap 14 and 15, and make sure the entries are otherwise sorted as they are now.

@nbdd0121 nbdd0121 force-pushed the postgres-state-version branch from f79dca3 to 23ff9d7 Compare September 9, 2023 21:03
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 9, 2023
@natsukium
Copy link
Copy Markdown
Member

natsukium commented Sep 10, 2023

This PR should go to staging.
https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#flow-of-merged-pull-requests

@ajs124 ajs124 marked this pull request as draft September 10, 2023 13:07
@nbdd0121 nbdd0121 changed the base branch from master to staging September 10, 2023 13:07
@ajs124 ajs124 marked this pull request as ready for review September 10, 2023 13:07
@kirillrdy
Copy link
Copy Markdown
Member

kirillrdy commented Sep 15, 2023

@nbdd0121 please rebase and fix merge conflicts

@nbdd0121 nbdd0121 force-pushed the postgres-state-version branch from 23ff9d7 to d3e28a4 Compare September 15, 2023 10:21
@nbdd0121
Copy link
Copy Markdown
Member Author

nbdd0121 commented Sep 15, 2023

Rebased

@kirillrdy
Copy link
Copy Markdown
Member

kirillrdy commented Sep 19, 2023

@nbdd0121 looks like conflict again

@kirillrdy
Copy link
Copy Markdown
Member

kirillrdy commented Sep 19, 2023

how about making 16 default for 23.11 ?

@nbdd0121
Copy link
Copy Markdown
Member Author

nbdd0121 commented Sep 19, 2023

I think psql 16 is too new for 23.11 release. IIUC timescaledb doesn't yet support psql 16. Probably would be better to wait a bit before making it the default.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 19, 2023
@nbdd0121 nbdd0121 force-pushed the postgres-state-version branch from d3e28a4 to 098c158 Compare September 19, 2023 14:45
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 19, 2023
@delroth delroth added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Sep 21, 2023
@yu-re-ka yu-re-ka merged commit e037977 into NixOS:staging Sep 27, 2023
@leona-ya
Copy link
Copy Markdown
Member

leona-ya commented Oct 1, 2023

I'm sorry to come up with this now, i haven't seen this PR before it got merged. I think users will probably get confused that services.postgresql.ensureUsers/ensureDatabases will not "just" work (see #216989 for context). imo we should use postgresql 14 for less confusion (it's okay if you feel different)

@SuperSandro2000
Copy link
Copy Markdown
Member

SuperSandro2000 commented Oct 1, 2023

We have 3 PRs to choose from to fix this: #203474 , #252071, #255961

@emilylange emilylange mentioned this pull request Oct 22, 2023
Merged
13 tasks
@mweinelt mweinelt mentioned this pull request Oct 22, 2023
Merged
13 tasks
@xanderio xanderio mentioned this pull request Oct 24, 2023
Closed
13 tasks
@devusb devusb mentioned this pull request Oct 30, 2023
Merged
13 tasks
@erikarvstedt erikarvstedt mentioned this pull request Nov 1, 2023
Closed
@nbdd0121 nbdd0121 deleted the postgres-state-version branch November 9, 2023 23:49
@bendlas bendlas mentioned this pull request Nov 10, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@anthonyroussel anthonyroussel Awaiting requested review from anthonyroussel

@WilliButz WilliButz Awaiting requested review from WilliButz

@gbtb gbtb Awaiting requested review from gbtb

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@nbdd0121 @natsukium @kirillrdy @leona-ya @SuperSandro2000 @thoughtpolice @delroth @yu-re-ka @NixOSInfra