Revert "treewide: change wafConfigureFlags to configureFlags"#254111
Closed
fabianhjr wants to merge 1 commit intoNixOS:staging-nextfrom
Closed
Revert "treewide: change wafConfigureFlags to configureFlags"#254111fabianhjr wants to merge 1 commit intoNixOS:staging-nextfrom
fabianhjr wants to merge 1 commit intoNixOS:staging-nextfrom
Conversation
This reverts commit 9f52275. Caused breakage on staging-next (2023-09-07) due to the following error: ``` waf: error: no such option: --sbindir ``` Reverted on staging after the cut, refer to NixOS#252874
Member
|
You should merge the revert commit from staging to staging-next |
Member
Member
Author
|
Changing to draft to avoid merge. |
Member
Author
|
This applies mostly cleanly on staging, except for a rename. I'm not sure a commit exists such that a conflict won't emerge. :s |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 9f52275.
Caused breakage on staging-next (2023-09-07) due to the following error:
Reverted on staging after the cut, refer to #252874
#253854
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)