Skip to content

mpir: fix build with clang 16#254015

Merged
7c6f434c merged 1 commit intoNixOS:masterfrom
reckenrode:mpir-fix
Sep 10, 2023
Merged

mpir: fix build with clang 16#254015
7c6f434c merged 1 commit intoNixOS:masterfrom
reckenrode:mpir-fix

Conversation

@reckenrode
Copy link
Copy Markdown
Contributor

Description of changes

Apply the patch from upstream, which fixes failing configure checks due to the use of implicitly defined exit.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Apply the patch from upstream, which fixes failing configure checks due
to the use of implicitly defined `exit`.
@ofborg ofborg bot requested a review from 7c6f434c September 8, 2023 12:23
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Sep 8, 2023
@reckenrode
Copy link
Copy Markdown
Contributor Author

Result of nixpkgs-review pr 254015 run on aarch64-darwin 1

32 packages marked as broken and skipped:
  • python310Packages.qiskit
  • python310Packages.qiskit-aer
  • python310Packages.qiskit-aer.dist
  • python310Packages.qiskit-finance
  • python310Packages.qiskit-finance.dist
  • python310Packages.qiskit-ibmq-provider
  • python310Packages.qiskit-ibmq-provider.dist
  • python310Packages.qiskit-ignis
  • python310Packages.qiskit-ignis.dist
  • python310Packages.qiskit-machine-learning
  • python310Packages.qiskit-machine-learning.dist
  • python310Packages.qiskit-nature
  • python310Packages.qiskit-nature.dist
  • python310Packages.qiskit-optimization
  • python310Packages.qiskit-optimization.dist
  • python310Packages.qiskit-terra
  • python310Packages.qiskit-terra.dist
  • python310Packages.qiskit.dist
  • python311Packages.qiskit-aer
  • python311Packages.qiskit-aer.dist
  • python311Packages.qiskit-finance
  • python311Packages.qiskit-finance.dist
  • python311Packages.qiskit-ibmq-provider
  • python311Packages.qiskit-ibmq-provider.dist
  • python311Packages.qiskit-ignis
  • python311Packages.qiskit-ignis.dist
  • python311Packages.qiskit-nature
  • python311Packages.qiskit-nature.dist
  • python311Packages.qiskit-optimization
  • python311Packages.qiskit-optimization.dist
  • python311Packages.qiskit-terra
  • python311Packages.qiskit-terra.dist
4 packages failed to build:
  • python310Packages.symengine
  • python310Packages.symengine.dist
  • python311Packages.symengine
  • python311Packages.symengine.dist
27 packages built:
  • antic
  • arb
  • calcium
  • flint
  • gfan
  • gnuradio
  • gnuradio3_8
  • gnuradio3_8Minimal
  • gnuradio3_8Packages.ais
  • gnuradio3_8Packages.gnuradio
  • gnuradio3_8Packages.grnet
  • gnuradio3_8Packages.osmosdr
  • gnuradio3_8Packages.osmosdr.dev
  • gnuradio3_8Packages.rds
  • gnuradio3_9
  • gnuradioMinimal (gnuradio3_9Minimal)
  • gnuradio3_9Packages.gnuradio
  • gnuradio3_9Packages.grnet
  • gnuradio3_9Packages.osmosdr
  • gnuradio3_9Packages.osmosdr.dev
  • gnuradioPackages.gnuradio
  • gnuradioPackages.osmosdr
  • gnuradioPackages.osmosdr.dev
  • mpir
  • pynac
  • singular
  • symengine

@reckenrode
Copy link
Copy Markdown
Contributor Author

Result of nixpkgs-review pr 254015 run on x86_64-darwin 1

32 packages marked as broken and skipped:
  • python310Packages.qiskit
  • python310Packages.qiskit-aer
  • python310Packages.qiskit-aer.dist
  • python310Packages.qiskit-finance
  • python310Packages.qiskit-finance.dist
  • python310Packages.qiskit-ibmq-provider
  • python310Packages.qiskit-ibmq-provider.dist
  • python310Packages.qiskit-ignis
  • python310Packages.qiskit-ignis.dist
  • python310Packages.qiskit-machine-learning
  • python310Packages.qiskit-machine-learning.dist
  • python310Packages.qiskit-nature
  • python310Packages.qiskit-nature.dist
  • python310Packages.qiskit-optimization
  • python310Packages.qiskit-optimization.dist
  • python310Packages.qiskit-terra
  • python310Packages.qiskit-terra.dist
  • python310Packages.qiskit.dist
  • python311Packages.qiskit-aer
  • python311Packages.qiskit-aer.dist
  • python311Packages.qiskit-finance
  • python311Packages.qiskit-finance.dist
  • python311Packages.qiskit-ibmq-provider
  • python311Packages.qiskit-ibmq-provider.dist
  • python311Packages.qiskit-ignis
  • python311Packages.qiskit-ignis.dist
  • python311Packages.qiskit-nature
  • python311Packages.qiskit-nature.dist
  • python311Packages.qiskit-optimization
  • python311Packages.qiskit-optimization.dist
  • python311Packages.qiskit-terra
  • python311Packages.qiskit-terra.dist
6 packages failed to build:
  • gnuradioPackages.osmosdr
  • gnuradioPackages.osmosdr.dev
  • python310Packages.symengine
  • python310Packages.symengine.dist
  • python311Packages.symengine
  • python311Packages.symengine.dist
25 packages built:
  • antic
  • arb
  • calcium
  • flint
  • gfan
  • gnuradio
  • gnuradio3_8
  • gnuradio3_8Minimal
  • gnuradio3_8Packages.ais
  • gnuradio3_8Packages.gnuradio
  • gnuradio3_8Packages.grnet
  • gnuradio3_8Packages.osmosdr
  • gnuradio3_8Packages.osmosdr.dev
  • gnuradio3_8Packages.rds
  • gnuradio3_9
  • gnuradioMinimal (gnuradio3_9Minimal)
  • gnuradio3_9Packages.gnuradio
  • gnuradio3_9Packages.grnet
  • gnuradio3_9Packages.osmosdr
  • gnuradio3_9Packages.osmosdr.dev
  • gnuradioPackages.gnuradio
  • mpir
  • pynac
  • singular
  • symengine

@reckenrode
Copy link
Copy Markdown
Contributor Author

reckenrode commented Sep 8, 2023

Result of nixpkgs-review pr 254015 run on x86_64-linux 1

36 packages failed to build:
  • python310Packages.qiskit
  • python310Packages.qiskit-aer
  • python310Packages.qiskit-aer.dist
  • python310Packages.qiskit-finance
  • python310Packages.qiskit-finance.dist
  • python310Packages.qiskit-ibmq-provider
  • python310Packages.qiskit-ibmq-provider.dist
  • python310Packages.qiskit-ignis
  • python310Packages.qiskit-ignis.dist
  • python310Packages.qiskit-machine-learning
  • python310Packages.qiskit-machine-learning.dist
  • python310Packages.qiskit-nature
  • python310Packages.qiskit-nature.dist
  • python310Packages.qiskit-optimization
  • python310Packages.qiskit-optimization.dist
  • python310Packages.qiskit-terra
  • python310Packages.qiskit-terra.dist
  • python310Packages.qiskit.dist
  • python310Packages.symengine
  • python310Packages.symengine.dist
  • python311Packages.qiskit-aer
  • python311Packages.qiskit-aer.dist
  • python311Packages.qiskit-finance
  • python311Packages.qiskit-finance.dist
  • python311Packages.qiskit-ibmq-provider
  • python311Packages.qiskit-ibmq-provider.dist
  • python311Packages.qiskit-ignis
  • python311Packages.qiskit-ignis.dist
  • python311Packages.qiskit-nature
  • python311Packages.qiskit-nature.dist
  • python311Packages.qiskit-optimization
  • python311Packages.qiskit-optimization.dist
  • python311Packages.qiskit-terra
  • python311Packages.qiskit-terra.dist
  • python311Packages.symengine
  • python311Packages.symengine.dist
41 packages built:
  • antic
  • arb
  • calcium
  • cantor
  • flint
  • gfan
  • gnss-sdr
  • gnuradio
  • gnuradio3_8
  • gnuradio3_8Minimal
  • gnuradio3_8Packages.ais
  • gnuradio3_8Packages.gnuradio
  • gnuradio3_8Packages.grnet
  • gnuradio3_8Packages.limesdr
  • gnuradio3_8Packages.osmosdr
  • gnuradio3_8Packages.osmosdr.dev
  • gnuradio3_8Packages.rds
  • gnuradio3_9
  • gnuradioMinimal (gnuradio3_9Minimal)
  • gnuradio3_9Packages.gnuradio
  • gnuradio3_9Packages.grnet
  • gnuradio3_9Packages.osmosdr
  • gnuradio3_9Packages.osmosdr.dev
  • gnuradioPackages.gnuradio
  • gnuradioPackages.osmosdr
  • gnuradioPackages.osmosdr.dev
  • gqrx
  • gqrx-gr-audio
  • gqrx-portaudio
  • inspectrum
  • kmymoney
  • labplot
  • libsForQt5.alkimia
  • mpir
  • polymake
  • pynac
  • qradiolink
  • sage
  • sageWithDoc
  • singular
  • symengine

@reckenrode
Copy link
Copy Markdown
Contributor Author

Result of nixpkgs-review pr 254015 run on aarch64-linux 1

36 packages failed to build:
  • python310Packages.qiskit
  • python310Packages.qiskit-aer
  • python310Packages.qiskit-aer.dist
  • python310Packages.qiskit-finance
  • python310Packages.qiskit-finance.dist
  • python310Packages.qiskit-ibmq-provider
  • python310Packages.qiskit-ibmq-provider.dist
  • python310Packages.qiskit-ignis
  • python310Packages.qiskit-ignis.dist
  • python310Packages.qiskit-machine-learning
  • python310Packages.qiskit-machine-learning.dist
  • python310Packages.qiskit-nature
  • python310Packages.qiskit-nature.dist
  • python310Packages.qiskit-optimization
  • python310Packages.qiskit-optimization.dist
  • python310Packages.qiskit-terra
  • python310Packages.qiskit-terra.dist
  • python310Packages.qiskit.dist
  • python310Packages.symengine
  • python310Packages.symengine.dist
  • python311Packages.qiskit-aer
  • python311Packages.qiskit-aer.dist
  • python311Packages.qiskit-finance
  • python311Packages.qiskit-finance.dist
  • python311Packages.qiskit-ibmq-provider
  • python311Packages.qiskit-ibmq-provider.dist
  • python311Packages.qiskit-ignis
  • python311Packages.qiskit-ignis.dist
  • python311Packages.qiskit-nature
  • python311Packages.qiskit-nature.dist
  • python311Packages.qiskit-optimization
  • python311Packages.qiskit-optimization.dist
  • python311Packages.qiskit-terra
  • python311Packages.qiskit-terra.dist
  • python311Packages.symengine
  • python311Packages.symengine.dist
41 packages built:
  • antic
  • arb
  • calcium
  • cantor (libsForQt5.cantor ,plasma5Packages.cantor)
  • flint
  • gfan
  • gnss-sdr
  • gnuradio
  • gnuradio3_8
  • gnuradio3_8Minimal
  • gnuradio3_8Packages.ais
  • gnuradio3_8Packages.gnuradio
  • gnuradio3_8Packages.grnet
  • gnuradio3_8Packages.limesdr
  • gnuradio3_8Packages.osmosdr
  • gnuradio3_8Packages.osmosdr.dev
  • gnuradio3_8Packages.rds
  • gnuradio3_9
  • gnuradioMinimal (gnuradio3_9Minimal)
  • gnuradio3_9Packages.gnuradio
  • gnuradio3_9Packages.grnet
  • gnuradio3_9Packages.osmosdr
  • gnuradio3_9Packages.osmosdr.dev
  • gnuradioPackages.gnuradio
  • gnuradioPackages.osmosdr
  • gnuradioPackages.osmosdr.dev
  • gqrx
  • gqrx-gr-audio
  • gqrx-portaudio
  • inspectrum
  • kmymoney
  • labplot
  • libsForQt5.alkimia (plasma5Packages.alkimia)
  • mpir
  • polymake
  • pynac
  • qradiolink
  • sage
  • sageWithDoc
  • singular
  • symengine

@7c6f434c 7c6f434c merged commit 73fe70b into NixOS:master Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants