Skip to content

lib/systems: disable pipewireSupport in qemu-user#253913

Merged
Artturin merged 1 commit intoNixOS:masterfrom
Artturin:qeminfrec
Sep 7, 2023
Merged

lib/systems: disable pipewireSupport in qemu-user#253913
Artturin merged 1 commit intoNixOS:masterfrom
Artturin:qeminfrec

Conversation

@Artturin
Copy link
Copy Markdown
Member

@Artturin Artturin commented Sep 7, 2023

Option added in 5b0ed68

it causes infinite recursion in cross builds

There's a another inf rec that needs 6946977 which is in staging

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Option added in 5b0ed68

it causes infinite recursion in cross builds

There's a another inf rec that needs 6946977 which is in staging
@Artturin Artturin requested a review from a user September 7, 2023 21:26
@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label Sep 7, 2023
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 7, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 7, 2023
@Artturin Artturin merged commit 32f2fb3 into NixOS:master Sep 7, 2023
@Artturin Artturin deleted the qeminfrec branch September 7, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: lib The Nixpkgs function library 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants