netcdf: fix build with clang 16 and tests on aarch64-darwin#253762
Merged
Mindavi merged 4 commits intoNixOS:masterfrom Sep 7, 2023
Merged
netcdf: fix build with clang 16 and tests on aarch64-darwin#253762Mindavi merged 4 commits intoNixOS:masterfrom
Mindavi merged 4 commits intoNixOS:masterfrom
Conversation
Clang 16 fails to build netcdf when using the HDF5 compatibility API due to incompatible function pointer conversion errors. Fortunately, 4.9.2 supports HDF15, so using the compatibility API can be disabled.
`nczarr_test/Makefile.am` prepends new shebang lines to the start of some tests when they are built, which breaks tests on Linux because `/bin/bash` does not exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Updating netcdf allows it to work without needing the compatibility API, which fixes the build with clang 16.
This PR also enables tests on aarch64-darwin (since they now work) and fixes them on Linux after the update.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)