timidity: fix build with clang 16#253725
Merged
toonn merged 1 commit intoNixOS:masterfrom Oct 9, 2023
Merged
Conversation
* Work around failing configure tests. Specify the expected value explictly except when that doesn’t work. Otherwise, patch the configure script to perform the test correctly with clang 16; * Add libobjc on Darwin; and * Use memstreamHook on x86_64-darwin;
toonn
reviewed
Sep 29, 2023
Contributor
toonn
left a comment
There was a problem hiding this comment.
Only a single nit to pick.
toonn
approved these changes
Oct 9, 2023
Contributor
toonn
left a comment
There was a problem hiding this comment.
LGTM, builds on both Darwins and x86_64-linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I tested Timidity using Jack 2 for playback. Native CoreAudio is pretty broken, but that also seems to be the case without the patch and building with clang 11.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)