Skip to content

SDL2_mixer_2_0: fix build with clang 16#253701

Merged
wegank merged 1 commit intoNixOS:masterfrom
reckenrode:sdl2-mixer-2.0-fix
Sep 6, 2023
Merged

SDL2_mixer_2_0: fix build with clang 16#253701
wegank merged 1 commit intoNixOS:masterfrom
reckenrode:sdl2-mixer-2.0-fix

Conversation

@reckenrode
Copy link
Copy Markdown
Contributor

Description of changes

Backport patches to fix incompatible pointer conversion errors.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Backport patches to fix incompatible pointer conversion errors.
@ofborg ofborg bot requested a review from MP2E September 6, 2023 20:46
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 6, 2023
@wegank
Copy link
Copy Markdown
Member

wegank commented Sep 6, 2023

Result of nixpkgs-review pr 253701 run on aarch64-darwin 1

2 packages built:
  • SDL2_mixer_2_0
  • SDL2_mixer_2_0.dev

@wegank wegank merged commit b123afb into NixOS:master Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants