mariadb-connector-odbc: fix build with clang 16 on Darwin#253532
Merged
toonn merged 1 commit intoNixOS:masterfrom Oct 5, 2023
Merged
mariadb-connector-odbc: fix build with clang 16 on Darwin#253532toonn merged 1 commit intoNixOS:masterfrom
toonn merged 1 commit intoNixOS:masterfrom
Conversation
* Use libkrb5 on Darwin; * Use nixpkgs zlib instead of vendored zlib to fix call to undeclared function `close`; and * Include `unistd.h` for `sleep`.
toonn
reviewed
Oct 5, 2023
Contributor
toonn
left a comment
There was a problem hiding this comment.
LGTM
The errors I get before this commit include the functions lseek, read, write and close in addition to sleep. I assume this is expected?
Contributor
Author
If they’re from the vendored zlib, they’re expected. |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
close; andunistd.hforsleep.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)