Skip to content

python3Packages.google-auth-oauthlib: fix test failure on Darwin#253338

Merged
toonn merged 1 commit intoNixOS:masterfrom
reckenrode:google-auth-oauthlib-fix
Sep 29, 2023
Merged

python3Packages.google-auth-oauthlib: fix test failure on Darwin#253338
toonn merged 1 commit intoNixOS:masterfrom
reckenrode:google-auth-oauthlib-fix

Conversation

@reckenrode
Copy link
Copy Markdown
Contributor

@reckenrode reckenrode commented Sep 5, 2023

Description of changes

Check phase fails on Darwin when socket.gethostname() returns None, which can happen when a hostname is not mapped to an IP address.

Testing is based on the successful execution of check phase.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 5, 2023
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Sep 5, 2023
@reckenrode reckenrode mentioned this pull request Sep 5, 2023
Closed
@ofborg ofborg bot requested a review from terlar September 5, 2023 01:30
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Sep 5, 2023
@wegank
Copy link
Copy Markdown
Member

wegank commented Sep 5, 2023

@ofborg build python3Packages.google-auth-oauthlib python3Packages.google-auth-oauthlib.passthru.tests

toonn
toonn approved these changes Sep 29, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@toonn toonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toonn toonn merged commit 7a0945c into NixOS:master Sep 29, 2023
@terlar
Copy link
Copy Markdown
Contributor

terlar commented Sep 29, 2023

Thanks, I didn't have the possibility to verify on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toonn toonn toonn approved these changes

@terlar terlar Awaiting requested review from terlar

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@reckenrode @wegank @terlar @toonn